Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shenxiaohu jira new #1998

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Conversation

cool-joker
Copy link
Contributor

Versions

  • dev
  • [x ] 3.0
  • 2.1
  • 2.0

Languages

  • Chinese
  • English

Docs Checklist

  • Checked by AI
  • Test Cases Built

1. Modify the name to coolown_datetime Cold and hot separation data migration time point:
## Optional Parameters

| 参数名称 | 描述 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要变成英文

```sql
CREATE STORAGE VAULT IF NOT EXISTS hdfs_vault_demo
PROPERTIES (
"type" = "hdfs", -- required
"fs.defaultFS" = "hdfs://127.0.0.1:8020", -- required
"path_prefix" = "big/data", -- optional
"path_prefix" = "big/data", -- optional, 一般按照业务名称填写
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有中文,把所有文档都检查一下吧,英文文档不要出现中文

@KassieZ KassieZ added the has comments Some comments not resolved yet label Feb 10, 2025
@KassieZ KassieZ requested a review from morrySnow February 12, 2025 07:00
@KassieZ KassieZ added request review and removed has comments Some comments not resolved yet labels Feb 12, 2025
@@ -1,6 +1,6 @@
---
{
"title": "ALTER STORAGE POLICY",
"title": "ALTER-STORAGE-POLICY",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

去掉标题中的减号

Comment on lines +41 to +49
## Optional Parameters

| Parameter Name | Description |
|-------------------|--------------------------------------------------------------|
| `retention_days` | Data retention period. Defines the duration for which the data is kept in storage. Data exceeding this period will be automatically deleted. |
| `redundancy_level`| Redundancy level. Defines the number of data replicas to ensure high availability and fault tolerance. For example, a value of 2 means each data block has two replicas. |
| `storage_type` | Storage type. Specifies the storage medium used, such as SSD, HDD, or hybrid storage. This affects performance and cost. |
| `cooloff_time` | Cool-off time. The time interval between when data is marked for deletion and when it is actually deleted. This helps prevent data loss due to accidental operations. |
| `location_policy` | Geographical location policy. Defines the geographical placement of data, such as cross-region replication for disaster recovery. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些都是 PROPERTIE ("<key>"="<value>"[, ... ]) 中 key 的候选。所以这里这样组织

  1. 在必选参数中,增加
`PROPERTIE ("<key>"="<value>"[, ... ])` 
  1. 然后这个表格跟在必选参数的表格后面,


```sql
CREATE STORAGE VAULT [IF NOT EXISTS] vault
[properties]
CREATE STORAGE VAULT [IF NOT EXISTS] <`vault_name`> [ <`properties`> ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CREATE STORAGE VAULT [IF NOT EXISTS] <`vault_name`> [ <`properties`> ]
CREATE STORAGE VAULT [IF NOT EXISTS] <vault_name> [ <properties> ]

| Parameter | Description |
|-------------------|--------------------------------------------------------------|
| `[IF NOT EXISTS]` | If the specified storage vault already exists, the creation operation will not be executed, and no error will be thrown. This prevents duplicate creation of the same storage vault. |
| `PROPERTIES` | A set of key-value pairs used to set or update specific properties of the storage vault. Each property consists of a key (<key>) and a value (<value>), separated by an equals sign (=). Multiple key-value pairs are separated by commas (,). |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `PROPERTIES` | A set of key-value pairs used to set or update specific properties of the storage vault. Each property consists of a key (<key>) and a value (<value>), separated by an equals sign (=). Multiple key-value pairs are separated by commas (,). |
| `<properties>` | A set of key-value pairs used to set or update specific properties of the storage vault. Each property consists of a key (`<key>`) and a value (`<value>`), separated by an equals sign (=). Multiple key-value pairs are separated by commas (,). |


| Parameter | Description |
|-------|-----------------------|
| `vault_name` | The name of the storage vault. This is the unique identifier for the new storage vault you are creating. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `vault_name` | The name of the storage vault. This is the unique identifier for the new storage vault you are creating. |
| `<vault_name>` | The name of the storage vault. This is the unique identifier for the new storage vault you are creating. |


| Parameter Name | Description |
|-------------------|--------------------------------------------------------------|
| `retention_days` | Data retention period. Defines the duration for which the data is kept in storage. Data exceeding this period will be automatically deleted. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

语句的参数,不是使用表格的形式,参考其他文档,如:https://doris.apache.org/docs/sql-manual/sql-statements/job/CREATE-JOB

@@ -0,0 +1,71 @@
---
{
"title": "SHOW STORAGE POLICY USING",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此文档和 show storage policy 重复,可以去除

* JSONB_PARSE_ERROR_TO_VALUE 同 `JSON_PARSE_ERROR_TO_VALUE`
* JSONB_PARSE_NOTNULL 同 `JSON_PARSE_NOTNULL`

`JSON_SEARCH` 函数用于在 JSON 文档中查找指定的值。如果找到该值,则返回值的路径。如果没有找到该值,则返回 `NULL`。该函数可以在 JSON 数据结构中递归查找。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

又把json parse 改成 json search 了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants